Replace topicMap with topicPartitions in cluster module #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixns
pushed a commit
to vixns/Burrow
that referenced
this pull request
Apr 3, 2019
* consistent with notifier executeTemplate * replace topicMap with topicPartitions * add partial partitions update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code use
topicMapto maptopictopartition count，and partition ID is 0, 1, 2, ...partitionCount- 1.However, if some partitions are broken (that is to say, these partitions have no leader), each time you call
getOffsets()method,fetchMetadatawill be set, leading to the result thattopic-freshandoffset-freshthese two configurations are meaningless.To solve this problem, I store each partition ID in a golang slice, when get metadata from the broker, check if partition has a leader, if true, then append it to the slice. I've initialized the slice's capacity with
partitionCount, andappendcan be called at mostpartitionCounttimes, so the capacity won't increase.Other issues:
errorTopics map[string]boolingenerateOffsetRequests()is unnecessary, I've founderrorTopicsis used for some complex logic in older codes.executeTemplate()in package notifier, the struct has a field named 'ID', but inconfig/default-http-post.tmpl, it's{{.Id}}.